Repository navigation
Add AppAPI configuration script and update Nextcloud configuration menu - #2792
Conversation
|
also cc @szaimen, what do you think? |
… and proxy setup for ExApps
…iated Docker containers
…r and HaRP daemon names
Refactor AppAPI configuration and related functions.
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive AppAPI (External Apps framework) configuration support to the Nextcloud VM, enabling users to deploy and manage containerized external applications. The implementation provides two deployment methods: HaRP (recommended for NC 32+) with reverse proxy support, and Direct Docker Socket for simpler local installations.
Key changes include:
- Added a new 691-line AppAPI configuration script with full deployment automation, GPU detection, and testing capabilities
- Integrated AppAPI option into the Nextcloud configuration menu with automatic disable logic for startup scenarios
- Added helper functions in lib.sh for AppAPI installation, daemon registration, and test app cleanup
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
| addons/appapi.sh | New comprehensive script handling AppAPI installation, Docker/HaRP daemon configuration, GPU detection, deployment testing, and cleanup |
| menu/nextcloud_configuration.sh | Added AppAPI as a configuration option with automatic disable logic during VM startup if not selected |
| lib.sh | Added helper functions for AppAPI: appapi_install() for variables/configuration, cleanup_test_app() for test cleanup, and register_daemon() for daemon registration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| choice=$(whiptail --title "$TITLE" --checklist \ | ||
| "Which settings do you want to configure? | ||
| $CHECKLIST_GUIDE\n\n$RUN_LATER_GUIDE" "$WT_HEIGHT" "$WT_WIDTH" 4 \ | ||
| "AppAPI" "(Configure External Apps framework - AppAPI daemon)" "$STARTUP_SWITCH" \ |
There was a problem hiding this comment.
The variable 'STARTUP_SWITCH' is referenced but never defined in this diff. Ensure this variable is properly initialized before the whiptail checklist, or it will evaluate to an empty string causing the AppAPI option to be unchecked by default.
| @@ -31,6 +31,7 @@ fi | |||
| choice=$(whiptail --title "$TITLE" --checklist \ | |||
| "Which settings do you want to configure? | |||
| $CHECKLIST_GUIDE\n\n$RUN_LATER_GUIDE" "$WT_HEIGHT" "$WT_WIDTH" 4 \ | |||
There was a problem hiding this comment.
The whiptail menu specifies '4' as the menu height parameter, but there are now 5 options listed (AppAPI, CookieLifetime, Share-folder, Disable workspaces, and Enable logrotate). The menu height should be updated to accommodate all options properly.
| $CHECKLIST_GUIDE\n\n$RUN_LATER_GUIDE" "$WT_HEIGHT" "$WT_WIDTH" 4 \ | |
| $CHECKLIST_GUIDE\n\n$RUN_LATER_GUIDE" "$WT_HEIGHT" "$WT_WIDTH" 8 \ |
Co-authored-by: Copilot <[email protected]> Signed-off-by: enoch85 <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: enoch85 <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: enoch85 <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: enoch85 <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: enoch85 <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: enoch85 <[email protected]>
@small1 Not tested, but a base at least