Skip to content

fix(NcDateTime): Respect language - #5501

Merged
Pytal merged 2 commits into
masterfrom
fix/date-time-lang
Apr 22, 2024
Merged

Pytal merged 2 commits into
masterfrom
fix/date-time-lang

Conversation

@Pytal

@Pytal Pytal commented Apr 17, 2024 •

Copy link
Copy Markdown
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews labels Apr 17, 2024
@Pytal Pytal added this to the 8.11.3 milestone Apr 17, 2024
@Pytal
Pytal requested review from ShGKme, nfebe and susnux April 17, 2024 17:52
@Pytal Pytal self-assigned this Apr 17, 2024
@Pytal
Pytal enabled auto-merge April 17, 2024 17:53
@Pytal
Pytal force-pushed the fix/date-time-lang branch 2 times, most recently from 45a124a to 8009bbb Compare April 17, 2024 18:03
@Pytal

Pytal commented Apr 17, 2024

Copy link
Copy Markdown
Contributor Author

/backport to next

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work, for example I have configured Nextcloud to use English (US) lanuage, but German locale (I want 24h system and dd.mm.yyyy days but English texts).
Now also english

Comment thread src/composables/useFormatDateTime.js Outdated
Comment thread src/composables/useFormatDateTime.js
@Pytal
Pytal force-pushed the fix/date-time-lang branch 2 times, most recently from 7876363 to 3149903 Compare April 19, 2024 17:40
@Pytal
Pytal requested a review from susnux April 19, 2024 17:44

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread tests/unit/components/NcDateTime/NcDateTime.spec.js Outdated
Comment thread tests/unit/components/NcDateTime/NcDateTime.spec.js Outdated
@ShGKme
ShGKme disabled auto-merge April 19, 2024 19:51
@susnux

susnux commented Apr 22, 2024

Copy link
Copy Markdown
Contributor

@Pytal conflicts + maybe include Grigoriis comments :)

@Pytal
Pytal force-pushed the fix/date-time-lang branch from 3149903 to 4f57f6d Compare April 22, 2024 23:41
@Pytal
Pytal enabled auto-merge April 22, 2024 23:42
@Pytal
Pytal merged commit e7ef548 into master Apr 22, 2024
@Pytal
Pytal deleted the fix/date-time-lang branch April 22, 2024 23:46
@backportbot backportbot Bot mentioned this pull request Apr 22, 2024
2 tasks done
@Antreesy Antreesy mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timestamps are not displayed in the preferred language

3 participants