Repository navigation
Conversation
Member
|
Yeh, but you still need to have them in tests :-( There is a discussion on this internally, it is a bug that needs to get fixed. But yeh, we can't remove this just yet... |
Member
Author
|
Im the guy who writes how to create PR and I forgot to run tests. That is a bug indeed. |
Member
|
Ref issue on the ng2 side: angular/angular#5433 |
Member
Author
|
Closed it by deleting the branch. |
Member
|
Should this be closed then? |
Member
|
Yeh, we are blocked on angular/angular#5433. I would vote for closing this PR and opening an issue instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As for alpha .46, there is no need to explicitly add core directives anymore, they are loaded at bootstrap.