Skip to content

Commit dcdee1e

Browse files
anidotnetclaude
anidotnet
and
claude
committed
Update MVStoreUtilsTest to H2's default versionsToKeep
The test pinned the values openOrCreate used to force. versionsToKeep is now H2's own 5; retentionTime stays 0 because an in-memory store has no chunks to retain and H2 sets that itself. Co-Authored-By: Claude Opus 5 <[email protected]>
1 parent 8c1edea commit dcdee1e

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

‎nitrite-mvstore-adapter/src/test/java/org/dizitart/no2/mvstore/MVStoreUtilsTest.java‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,11 @@ public class MVStoreUtilsTest {
2929
public void testOpenOrCreate() {
3030
MVStore actualOpenOrCreateResult = MVStoreUtils.openOrCreate(new MVStoreConfig());
3131
assertFalse(actualOpenOrCreateResult.isReadOnly());
32-
assertEquals(0L, actualOpenOrCreateResult.getVersionsToKeep());
32+
// H2's own default, no longer forced to 0
33+
assertEquals(5L, actualOpenOrCreateResult.getVersionsToKeep());
3334
assertEquals(0, actualOpenOrCreateResult.getUnsavedMemory());
3435
assertEquals(0, actualOpenOrCreateResult.getStoreVersion());
36+
// an in-memory store has no chunks to retain, so H2 keeps this at 0 by itself
3537
assertEquals(0, actualOpenOrCreateResult.getRetentionTime());
3638
assertEquals(0, actualOpenOrCreateResult.getMetaMap().size());
3739
assertEquals(Long.MAX_VALUE, actualOpenOrCreateResult.getMaxPageSize());
@@ -46,9 +48,11 @@ public void testOpenOrCreate2() {
4648
mvStoreConfig.addStoreEventListener(mock(StoreEventListener.class));
4749
MVStore actualOpenOrCreateResult = MVStoreUtils.openOrCreate(mvStoreConfig);
4850
assertFalse(actualOpenOrCreateResult.isReadOnly());
49-
assertEquals(0L, actualOpenOrCreateResult.getVersionsToKeep());
51+
// H2's own default, no longer forced to 0
52+
assertEquals(5L, actualOpenOrCreateResult.getVersionsToKeep());
5053
assertEquals(0, actualOpenOrCreateResult.getUnsavedMemory());
5154
assertEquals(0, actualOpenOrCreateResult.getStoreVersion());
55+
// an in-memory store has no chunks to retain, so H2 keeps this at 0 by itself
5256
assertEquals(0, actualOpenOrCreateResult.getRetentionTime());
5357
assertEquals(0, actualOpenOrCreateResult.getMetaMap().size());
5458
assertEquals(Long.MAX_VALUE, actualOpenOrCreateResult.getMaxPageSize());

0 commit comments

Comments
 (0)