Skip to content

The encoding module should be an optionalDependencies #675

Closed

Description

@ehmicky

The encoding module is conditionally required, i.e. should be an optionalDependencies in the package.json.

Doing so allows libraries that parse require() statements (using JavaScript AST) such as precinct to know whether a require() statement that cannot be resolved indicates an error or not.

This causes problems on our library zip-it-and-ship-it: netlify/zip-it-and-ship-it#16, netlify/zip-it-and-ship-it#30

Activity

  1. Richienb commented on Sep 19, 2019

    @Richienb
    Member

    Fixed in d68d0ef#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R66 and will be released in v3. It is also in the roadmap to rework the charset detection into a separate package so hold tight!

  2. ehmicky commented on Sep 19, 2019

    @ehmicky
    Author

    Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions