Skip to content

Give @shigeki access to linuxOne machine for openSSL work #1246

Description

@mhdawson

See: nodejs/node#19944 (comment)

@shigeki is a long standing Node.js collaborator and past TSC member

Activity

  1. mhdawson commented on Apr 20, 2018

    @mhdawson
    MemberAuthor

    +1
    @nodejs/build

  2. Trott commented on Apr 20, 2018

    @Trott
    Member

    +1

  3. gibfahn commented on Apr 22, 2018

    @gibfahn
    Member

    +1

  4. richardlau commented on Apr 23, 2018

    @richardlau
    Member

    Is this still required now nodejs/node#19944 has been closed?

  5. shigeki commented on Apr 23, 2018

    @shigeki

    If it allowed, I'd like to have an access it in order to check if OpenSSL-1.1.0 built with Node is properly by comparing those built from the OpenSSL sources. I also need to submit a patch for S390 of nodejs/node@1bcb6c0 to the upstream but I never checked it on that machine except CI jobs of Node.
    https://github.com/shigeki.keys are my public keys.

  6. Trott commented on Apr 23, 2018

    @Trott
    Member

    Aside: Looks like we may need to update the ansible stuff so that the ssh config writing playbook writes info for test-linuxonecc-rhel72-s390x-3? I'm only getting -1 and -2.

  7. Trott commented on Apr 23, 2018

    @Trott
    Member

    @shigeki I've added your public keys to test-linuxonecc-rhel72-s390x-2. Let me know if the work you're doing requires us to take it out of the CI rotation. When you're done, leave a comment here and I'll remove your keys (or remove them yourself) and close this issue.

  8. shigeki commented on Apr 24, 2018

    @shigeki

    @Trott Thanks. I can login the machine and make test builds of openssl and node in /data/shigeki. Build binaries were already transferred to my local machine but they are not yet checked. And checking my openssl PR is not yet done, too. Please keep my access for a while. I will ask you to remove my access after my all tasks finished. Thanks, again.

  9. mhdawson commented on Apr 24, 2018

    @mhdawson
    MemberAuthor

    @Trott good point on -3, I added those as one to test the new compiler changes, I'll figure out if I'm going to remove from the CI or add to ansible.

  10. gdams commented on May 30, 2018

    @gdams
    Member

    @shigeki is your access still required here?

  11. maclover7 commented on Jun 3, 2018

    @maclover7
    Contributor

    Removed access from test-linuxonecc-rhel72-s390x-2, easy enough to add back later if still needed

  12. shigeki commented on Jun 3, 2018

    @shigeki

    Thanks. I've confirmed that it's no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions