Skip to content

Add ability to skip on preRelease node / master #517

Closed

Description

@MylesBorins

There are a bunch of modules that fail on master for a number of reasons outside of our control including

  • missing binaries for phantomjs
  • rigid dependencies such as mock-fs
  • Simply broken and awaiting a fix

One issue is adding a flag for a specific release potentially won't be removed when that release is promoted unless we are on top of things... it also means we need to update for the new version number when we roll a new major for core. it would nice to see this process more streamlined.

Activity

  1. richardlau commented on Dec 5, 2017

    @richardlau
    Member

    Could we use the existing tagging mechanism to mark the modules that should be skipped for -pre versions of Node.js?

  2. MylesBorins commented on Dec 5, 2017

    @MylesBorins
    ContributorAuthor

    @richardlau the challenge is we don't want them to be skipped for pre's that are not tip of tree

  3. richardlau commented on Dec 5, 2017

    @richardlau
    Member

    I wasn't suggesting automating the skipping -- Merely that the tagging could be used to indicate which modules to skip and then citgm-all --excludeTags ... used to skip them.

  4. gdams commented on Dec 22, 2017

    @gdams
    Member

    I'm with @richardlau on this, let's work out which modules are failing on pre releases and then we can add a tag that can be skipped for release runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions