CITGM seems to be broken on master #536

Activity

1. joyeecheung commented on Jan 17, 2018

   

   joyeecheung

   on Jan 17, 2018

   MemberAuthor

   More actions

   Trace:

   error: failure             | spawn npm ENOENT    
   error: failure             | spawn npm ENOENT    
   /Users/iojs/build/workspace/citgm-smoker/nodes/osx1010/smoker/lib/node_modules/citgm/node_modules/async/dist/async.js:955
           if (fn === null) throw new Error("Callback was already called.");
                            ^
   
   Error: Callback was already called.
       at /Users/iojs/build/workspace/citgm-smoker/nodes/osx1010/smoker/lib/node_modules/citgm/node_modules/async/dist/async.js:955:32
       at ChildProcess.<anonymous> (/Users/iojs/build/workspace/citgm-smoker/nodes/osx1010/smoker/lib/node_modules/citgm/lib/grab-module-data.js:43:7)
       at ChildProcess.emit (events.js:131:13)
       at maybeClose (internal/child_process.js:943:16)
       at Socket.stream.socket.on (internal/child_process.js:363:11)
       at Socket.emit (events.js:131:13)
       at Pipe._handle.close [as _onclose] (net.js:592:12)
   Build step 'Conditional steps (multiple)' marked build as failure
   
2. addaleax commented on Jan 17, 2018

   

   addaleax

   on Jan 17, 2018

   Member

   More actions

   error: failure | spawn npm ENOENT

   Sounds like something for @nodejs/build too?
3. joyeecheung commented on Jan 17, 2018

   

   joyeecheung

   on Jan 17, 2018

   MemberAuthor

   More actions

   @addaleax No, looks like something is broken on master. I am currently bisecting between 1385e1bc63(good) 85739b6c5b(bad)

   👍React with 👍1Reacted by Anna Henningsen
4. apapirovski commented on Jan 17, 2018

   

   apapirovski

   on Jan 17, 2018

   More actions

   I've got the fix: nodejs/node#18210

   👍React with 👍2Reacted by Joyee Cheung and Gibson Fahnestock
5. apapirovski

   added a commit that references this issue on Jan 18, 2018

   child_process: do not ignore proto values of env

   ...

   38ee25e
6. jasnell

   closed this as completedin 38ee25eon Jan 18, 2018
7. MayaLekova

   added a commit that references this issue on May 8, 2018

   child_process: do not ignore proto values of env

   ...

   53ea1a0