Skip to content

Commit 77542a5

Browse files
mmarchiniBethGriggs
mmarchini
authored and
BethGriggs
committed
deps: revert whitespace changes on V8
While landing the upgrade to V8 8.1, something went wrong and git made unecessary (and incorrect) whitespace changes to test fixtures, which broke V8 tests. Revert those changes to fix our tests. PR-URL: #32587 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
1 parent 440e1ad commit 77542a5

4 files changed

Lines changed: 18 additions & 17 deletions

File tree

‎deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateMethodAccess.golden‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ snippet: "
111111
#d() { return 1; }
112112
constructor() { (() => this)().#d(); }
113113
}
114-
114+
115115
var test = D;
116116
new test;
117117
"
@@ -147,3 +147,4 @@ constant pool: [
147147
]
148148
handlers: [
149149
]
150+

‎deps/v8/test/inspector/debugger/class-private-methods-preview-expected.txt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ expression: new class { #method() { return 1; } get #accessor() { } set #accesso
99
[0] : {
1010
name : #method
1111
type : function
12-
value :
12+
value :
1313
}
1414
[1] : {
1515
name : #accessor
@@ -21,7 +21,7 @@ expression: new class extends class { #method() { return 1; } } { get #accessor(
2121
[0] : {
2222
name : #method
2323
type : function
24-
value :
24+
value :
2525
}
2626
[1] : {
2727
name : #accessor

‎deps/v8/test/inspector/debugger/wasm-scope-info-liftoff-expected.txt‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ at C (interpreted) (0:85):
1717
globals: "global#0": 0 (number)
1818
- scope (local):
1919
locals: "i32_arg": 42 (number), "i32_local": 0 (number)
20-
stack:
20+
stack:
2121
at B (liftoff) (0:76):
2222
- scope (global):
2323
globals: "global#0": 0 (number)
@@ -29,7 +29,7 @@ at A (liftoff) (0:54):
2929
globals: "global#0": 0 (number)
3030
- scope (local):
3131
locals: "arg#0": 42 (number)
32-
stack:
32+
stack:
3333
at (anonymous) (0:17):
3434
- scope (global):
3535
-- skipped globals
@@ -54,7 +54,7 @@ at A (liftoff) (0:54):
5454
globals: "global#0": 0 (number)
5555
- scope (local):
5656
locals: "arg#0": 42 (number)
57-
stack:
57+
stack:
5858
at (anonymous) (0:17):
5959
- scope (global):
6060
-- skipped globals
@@ -67,7 +67,7 @@ at C (interpreted) (0:89):
6767
globals: "global#0": 42 (number)
6868
- scope (local):
6969
locals: "i32_arg": 42 (number), "i32_local": 0 (number)
70-
stack:
70+
stack:
7171
at B (liftoff) (0:76):
7272
- scope (global):
7373
globals: "global#0": 42 (number)
@@ -79,7 +79,7 @@ at A (liftoff) (0:54):
7979
globals: "global#0": 42 (number)
8080
- scope (local):
8181
locals: "arg#0": 42 (number)
82-
stack:
82+
stack:
8383
at (anonymous) (0:17):
8484
- scope (global):
8585
-- skipped globals
@@ -104,7 +104,7 @@ at A (liftoff) (0:54):
104104
globals: "global#0": 42 (number)
105105
- scope (local):
106106
locals: "arg#0": 42 (number)
107-
stack:
107+
stack:
108108
at (anonymous) (0:17):
109109
- scope (global):
110110
-- skipped globals
@@ -117,7 +117,7 @@ at C (interpreted) (0:93):
117117
globals: "global#0": 42 (number)
118118
- scope (local):
119119
locals: "i32_arg": 42 (number), "i32_local": 47 (number)
120-
stack:
120+
stack:
121121
at B (liftoff) (0:76):
122122
- scope (global):
123123
globals: "global#0": 42 (number)
@@ -129,7 +129,7 @@ at A (liftoff) (0:54):
129129
globals: "global#0": 42 (number)
130130
- scope (local):
131131
locals: "arg#0": 42 (number)
132-
stack:
132+
stack:
133133
at (anonymous) (0:17):
134134
- scope (global):
135135
-- skipped globals

‎deps/v8/test/inspector/runtime/evaluate-repl-await-expected.txt‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ Tests that top-level await in Runtime.evaluate REPL mode includes stack trace.
1414
callFrames : [
1515
[0] : {
1616
columnNumber : 0
17-
functionName :
17+
functionName :
1818
lineNumber : 0
1919
scriptId : <scriptId>
20-
url :
20+
url :
2121
}
2222
]
2323
}
@@ -50,21 +50,21 @@ Tests that top-level await in Runtime.evaluate REPL mode includes stack trace.
5050
functionName : bar
5151
lineNumber : 2
5252
scriptId : <scriptId>
53-
url :
53+
url :
5454
}
5555
[1] : {
5656
columnNumber : 6
5757
functionName : foo
5858
lineNumber : 6
5959
scriptId : <scriptId>
60-
url :
60+
url :
6161
}
6262
[2] : {
6363
columnNumber : 4
64-
functionName :
64+
functionName :
6565
lineNumber : 9
6666
scriptId : <scriptId>
67-
url :
67+
url :
6868
}
6969
]
7070
}

0 commit comments

Comments
 (0)