Skip to content

Commit 94e1213

Browse files
joyeecheungaduh95
authored andcommitted
build: derive V8_LOGGING_LEVEL from dcheck_always_on
Signed-off-by: Joyee Cheung <[email protected]> PR-URL: #65744 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7705483 Reviewed-By: Richard Lau <[email protected]>
1 parent d319fa7 commit 94e1213

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

‎tools/v8_gypfiles/features.gypi‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,9 +464,21 @@
464464
'defines': ['V8_ENABLE_SEEDED_ARRAY_INDEX_HASH',],
465465
}],
466466
['dcheck_always_on!=0', {
467-
'defines': ['DEBUG',],
467+
'defines': [
468+
'DEBUG',
469+
'V8_LOGGING_LEVEL=2', # Print file, line, message on fatal checks
470+
],
468471
}, {
469472
'defines': ['NDEBUG',],
473+
'configurations': {
474+
'Debug': {
475+
'defines': ['V8_LOGGING_LEVEL=2',],
476+
},
477+
'Release': {
478+
# Only log message (without file or line) on fatal checks
479+
'defines': ['V8_LOGGING_LEVEL=1',],
480+
},
481+
},
470482
}],
471483
['v8_enable_verify_csa==1', {
472484
'defines': ['ENABLE_VERIFY_CSA',],

0 commit comments

Comments
 (0)