Skip to content

Commit b9b0e33

Browse files
HoonDongKangaduh95
HoonDongKang
authored and
aduh95
committed
lib: avoid unsafe array iteration in cli table
Avoid unsafe array iteration because for...of relies on the user-mutable Symbol.iterator. Use an index-based loop instead. Signed-off-by: HoonDongKang <[email protected]> PR-URL: #65838 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Jordan Harband <[email protected]>
1 parent 9a3697c commit b9b0e33

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎lib/internal/cli_table.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,10 @@ const table = (head, columns) => {
8181
ArrayPrototypeJoin(divider, tableChars.rowMiddle) +
8282
tableChars.rightMiddle + '\n';
8383

84-
for (const row of rows)
84+
for (let i = 0; i < rows.length; i++) {
85+
const row = rows[i];
8586
result += `${renderRow(row, columnWidths)}\n`;
87+
}
8688

8789
result += tableChars.bottomLeft +
8890
ArrayPrototypeJoin(divider, tableChars.bottomMiddle) +

0 commit comments

Comments
 (0)