Repository navigation
Comparing changes
Open a pull request
base repository: nodejs/node
base: a984551
head repository: nodejs/node
compare: 2a6ab9b
- 17 commits
- 37 files changed
- 11 contributors
Commits on Apr 12, 2018
-
doc: remove superfluous word from crypto doc
PR-URL: #19946 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0aab8ff - Browse repository at this point
Copy the full SHA 0aab8ffView commit details -
test: fixed flaky test-http-readable-data-event
Fixes: #19905 PR-URL: #19931 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5a8fcd0 - Browse repository at this point
Copy the full SHA 5a8fcd0View commit details -
assert: provide info about actual error
In case a error is caught in `assert.doesNotThrow` or `assert.doesNotReject` it will now also indicate what the real error message was. PR-URL: #19884 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2bee799 - Browse repository at this point
Copy the full SHA 2bee799View commit details -
doc: added ready events to fs/streams,net/socket
PR-URL: #19968 Fixes: #19796 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e3f133a - Browse repository at this point
Copy the full SHA e3f133aView commit details -
doc: fix punctuation and wrapping in buffer.md
Remove unnecessary colons and wrap lines at 80 characters. PR-URL: #19964 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0815555 - Browse repository at this point
Copy the full SHA 0815555View commit details -
doc: fix errors in sample code comments
The errors thrown have changed in a few places. Update the comments to reflect the current errors. The `noAssert` option has been removed but it is still shown in sample code in a few places. Remove that sample code. PR-URL: #19963 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3bd6d8d - Browse repository at this point
Copy the full SHA 3bd6d8dView commit details -
src: add node_internal.h includes for arraysize
This commit adds includes for node_internal.h in source files that use arraysize but don't include this header. The motivation for this is to make refactoring easier (and is the reason I noticed this). PR-URL: #19916 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0e81117 - Browse repository at this point
Copy the full SHA 0e81117View commit details -
errors: pass missing
messageparameter tointernalAssertPasses the `message` parameter to `internalAssert` when `ERR_INVALID_ARG_TYPE` is thrown with invalid arguments. PR-URL: #19908 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bb6de0d - Browse repository at this point
Copy the full SHA bb6de0dView commit details -
net,http2: merge write error handling & property names
Merge error handling for `net.Socket`s and `Http2Stream`s, and align the callback property names as `callback`. Refs: #19060 PR-URL: #19734 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 93967d0 - Browse repository at this point
Copy the full SHA 93967d0View commit details -
http2: fix ping duration calculation
PR-URL: #19956 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 039cdeb - Browse repository at this point
Copy the full SHA 039cdebView commit details -
util: introduce
formatWithOptions()Identical to `format()` except that it takes an options argument that is passed through to `inspect()`. PR-URL: #19372 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 681c1d2 - Browse repository at this point
Copy the full SHA 681c1d2View commit details -
doc: document
Console(…, ignoreErrors)optionPR-URL: #19372 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6576598 - Browse repository at this point
Copy the full SHA 6576598View commit details -
console: allow
optionsobject as constructor argPR-URL: #19372 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ce58df5 - Browse repository at this point
Copy the full SHA ce58df5View commit details -
Add a way to tell `Console` instances to either always use, never use or auto-detect color support and inspect objects accordingly. PR-URL: #19372 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 57e8793 - Browse repository at this point
Copy the full SHA 57e8793View commit details -
console: auto-detect color support by default
This makes Node pretty-print objects with color by default when `console.log()`-ing them. PR-URL: #19372 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 565fd50 - Browse repository at this point
Copy the full SHA 565fd50View commit details -
doc: move trevnorris to TSC Emeritus
I'll still be around, but won't be able to contribute enough to merit TSC status. PR-URL: #19985 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 636bac7 - Browse repository at this point
Copy the full SHA 636bac7View commit details
Commits on Apr 13, 2018
-
doc: add pronouns for ofrobots
PR-URL: #19992 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2a6ab9b - Browse repository at this point
Copy the full SHA 2a6ab9bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff a984551...2a6ab9b