Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a984551
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2a6ab9b
Choose a head ref
  • 17 commits
  • 37 files changed
  • 11 contributors

Commits on Apr 12, 2018

  1. doc: remove superfluous word from crypto doc

    PR-URL: #19946
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Anatoli Papirovski <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Vse Mozhet Byt <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    tniessen authored and trivikr committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    0aab8ff View commit details
    Browse the repository at this point in the history
  2. test: fixed flaky test-http-readable-data-event

    Fixes: #19905
    
    PR-URL: #19931
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    mcollina committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    5a8fcd0 View commit details
    Browse the repository at this point in the history
  3. assert: provide info about actual error

    In case a error is caught in `assert.doesNotThrow` or
    `assert.doesNotReject` it will now also indicate what the real
    error message was.
    
    PR-URL: #19884
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    BridgeAR committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    2bee799 View commit details
    Browse the repository at this point in the history
  4. doc: added ready events to fs/streams,net/socket

    PR-URL: #19968
    Fixes: #19796
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Vse Mozhet Byt <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    towc authored and BridgeAR committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    e3f133a View commit details
    Browse the repository at this point in the history
  5. doc: fix punctuation and wrapping in buffer.md

    Remove unnecessary colons and wrap lines at 80 characters.
    
    PR-URL: #19964
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Gibson Fahnestock <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Vse Mozhet Byt <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Trott authored and BridgeAR committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    0815555 View commit details
    Browse the repository at this point in the history
  6. doc: fix errors in sample code comments

    The errors thrown have changed in a few places. Update the comments to
    reflect the current errors.
    
    The `noAssert` option has been removed but it is still shown in sample
    code in a few places. Remove that sample code.
    
    PR-URL: #19963
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Daniel Bevenius <[email protected]>
    Reviewed-By: Vse Mozhet Byt <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Trott authored and BridgeAR committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    3bd6d8d View commit details
    Browse the repository at this point in the history
  7. src: add node_internal.h includes for arraysize

    This commit adds includes for node_internal.h in source files that use
    arraysize but don't include this header. The motivation for this is to
    make refactoring easier (and is the reason I noticed this).
    
    PR-URL: #19916
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gibson Fahnestock <[email protected]>
    danbev authored and BridgeAR committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    0e81117 View commit details
    Browse the repository at this point in the history
  8. errors: pass missing message parameter to internalAssert

    Passes the `message` parameter to `internalAssert` when
    `ERR_INVALID_ARG_TYPE` is thrown with invalid arguments.
    
    PR-URL: #19908
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    AyushG3112 authored and BridgeAR committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    bb6de0d View commit details
    Browse the repository at this point in the history
  9. net,http2: merge write error handling & property names

    Merge error handling for `net.Socket`s and `Http2Stream`s,
    and align the callback property names as `callback`.
    
    Refs: #19060
    
    PR-URL: #19734
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    addaleax committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    93967d0 View commit details
    Browse the repository at this point in the history
  10. http2: fix ping duration calculation

    PR-URL: #19956
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    jasnell committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    039cdeb View commit details
    Browse the repository at this point in the history
  11. util: introduce formatWithOptions()

    Identical to `format()` except that it takes an options argument
    that is passed through to `inspect()`.
    
    PR-URL: #19372
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    addaleax committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    681c1d2 View commit details
    Browse the repository at this point in the history
  12. doc: document Console(…, ignoreErrors) option

    PR-URL: #19372
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    addaleax committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    6576598 View commit details
    Browse the repository at this point in the history
  13. console: allow options object as constructor arg

    PR-URL: #19372
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    addaleax committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    ce58df5 View commit details
    Browse the repository at this point in the history
  14. console: add color support

    Add a way to tell `Console` instances to either always use, never use
    or auto-detect color support and inspect objects accordingly.
    
    PR-URL: #19372
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    addaleax committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    57e8793 View commit details
    Browse the repository at this point in the history
  15. console: auto-detect color support by default

    This makes Node pretty-print objects with color by default
    when `console.log()`-ing them.
    
    PR-URL: #19372
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    addaleax committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    565fd50 View commit details
    Browse the repository at this point in the history
  16. doc: move trevnorris to TSC Emeritus

    I'll still be around, but won't be able to contribute enough to merit
    TSC status.
    
    PR-URL: #19985
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    trevnorris authored and Trott committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    636bac7 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2018

  1. doc: add pronouns for ofrobots

    PR-URL: #19992
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: Yuta Hiroto <[email protected]>
    Reviewed-By: Gus Caplan <[email protected]>
    Reviewed-By: Vse Mozhet Byt <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    ofrobots authored and MylesBorins committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    2a6ab9b View commit details
    Browse the repository at this point in the history
Loading