meta: commit messages with long URLs #17116

Activity

1. vsemozhetbyt

   added

   docIssues and PRs related to Node.js documentation.Issues and PRs related to Node.js documentation.

   metaIssues and PRs related to the general management of the project.Issues and PRs related to the general management of the project.

   on Nov 18, 2017
2. joyeecheung commented on Nov 18, 2017

   

   joyeecheung

   on Nov 18, 2017

   Member

   More actions

   I think there aren't really any workaround for this anyway? This is similar to the ignoreUrls option of max-length in eslint.

   👍React with 👍1Reacted by Vse Mozhe Buty
3. vsemozhetbyt commented on Nov 18, 2017

   

   vsemozhetbyt

   on Nov 18, 2017

   ContributorAuthor

   More actions

   @joyeecheung We can use some URL shortener, but this can mess things up.
4. gibfahn commented on Dec 28, 2017

   

   gibfahn

   on Dec 28, 2017

   Member

   More actions

   Should we alleviate the 72 characters rule for lines with long URLs and note about it in the COLLABORATOR_GUIDE.md?

   I think this is what we've always done anyway, so why not make it explicit.

   👍React with 👍2Reacted by Anna Henningsen and Ruben Bridgewater
5. mhdawson commented on Jan 3, 2018

   

   mhdawson

   on Jan 3, 2018

   Member

   More actions

   +1 to what @gibfahn said.
6. vsemozhetbyt

   closed this as completedin 2060787on Apr 22, 2018
7. jasnell

   added a commit that references this issue on Apr 23, 2018

   meta: document commit msg exception for long URLs

   ...

   d591a59
8. sjarmak

   added a commit that references this issue on Jul 27, 2026

   meta: document commit msg exception for long URLs

   ...

   2060787