Repository navigation
tracing: etw/perf/lttng/etc multi-isolate support #18074
Description
Continuing from nodejs/help#1031: src/node_counters.cc and its ilk need to have their initialization split out into a per-isolate and per-context step for embedding to work with them. Some thoughts:
-
node.js won't know if initialization already happened if the isolate is created by the embedder, unless extra bookkeeping is added. Could hang off
MultiIsolatePlatform::RegisterIsolate()- or could it? -
the tracing code itself isn't multi-isolate ready in the slightest, it's all globals that need to move to
IsolateDataandEnvironment -
some tracing flavors have (possibly inevitable) process-global state that should be protected by a
uv_once_tornode::Mutex.
Activity
smeshch commentedon Jan 25, 2018
I think this line and next one (which set callbacks to isolate) should not depends on
Environment(embedder can create one isolate and set it for everyEnvironment,that will be created). IMHO, adding callbacks should be somewhere inNodePlatformclass, when it registers isolate.Trott commentedon Aug 2, 2019
@bnoordhuis This should remain open, yes? If so, is there someone particularly well-suited to try to move it forward? @nodejs/embedders maybe?
bnoordhuis commentedon Aug 3, 2019
Yes, it's still an issue. I don't have suggestions for volunteers but they're more than welcome.
bnoordhuis commentedon Dec 2, 2022
I think this issue has become obsolete after the removal of dtrace and etw in #43652 (and lttng and perfctr back in 2018.) I'll go ahead and close it.