readDoubleLE broken on 9.4.0 #18419

Activity

1. vsemozhetbyt

   added

   bufferIssues and PRs related to the buffer subsystem.Issues and PRs related to the buffer subsystem.

   on Jan 28, 2018
2. BridgeAR commented on Jan 28, 2018

   

   BridgeAR

   on Jan 28, 2018

   Member

   More actions

   Hm, this is going to be fixed on master in #18395.

   I am going to open a backport of that PR without any semver-major changes that will also fix that problem.
3. BridgeAR

   self-assigned this

   on Jan 28, 2018
4. BridgeAR

   added

   confirmed-bugIssues and PRs for confirmed bugs.Issues and PRs for confirmed bugs.

   on Jan 28, 2018
5. ChALkeR commented on Jan 28, 2018

   

   ChALkeR

   on Jan 28, 2018

   Last edited by ChALkeR

   Member

   More actions

   It looks like only the version without the offset parameter is broken?

   > Buffer.from([0xeb, 0x97, 0x3a, 0x98, 0x20, 0xdb, 0xc2, 0x40]).readDoubleLE(0);
   9654.254645656756
   > Buffer.from([0xeb, 0x97, 0x3a, 0x98, 0x20, 0xdb, 0xc2, 0x40]).readDoubleLE();
   -5.828774743119337e-192
   

   The bad thing is that there are currently no tests for the offset-less versions of those functions.
6. BridgeAR commented on Jan 29, 2018

   

   BridgeAR

   on Jan 29, 2018

   Member

   More actions

   @ChALkeR you are right and that got already fixed by #18215.
7. BridgeAR

   closed this as completedon Jan 29, 2018
8. BridgeAR commented on Jan 29, 2018

   

   BridgeAR

   on Jan 29, 2018

   Member

   More actions

   @arthurschreiber the next minor is going to contain that fix. Nevertheless it is recommended to always explicitly pass the offset. It is not meant as optional argument.