internal check macros don't work #19503

Activity

1. devsnek commented on Mar 21, 2018

   

   devsnek

   on Mar 21, 2018

   Last edited by devsnek

   Member

   More actions

   @targos interesting, I didn't observe that behaviour while testing. as it is the code is taken from v8's JS2C script so I don't know much about its specific workings. I can try to take a look later today.
2. devsnek commented on Mar 23, 2018

   

   devsnek

   on Mar 23, 2018

   Member

   More actions

   @targos i can't reproduce this.
3. BridgeAR commented on Apr 12, 2018

   

   BridgeAR

   on Apr 12, 2018

   Member

   More actions

   I just checked this and I am able to reproduce the problem.

   CHECK(condition);
   CHECK_EQ(condition, true);
   DCHECK(condition);
   DCHECK_EQ(condition, true);
   // Becomes
   do { if (!(condition)) (process._rawDebug("CHECK: condition == true"), process.abort()) } while (0);
   CHECK((condition) === (true));
   void(condition);
   void(condition, true);
4. BridgeAR

   added

   confirmed-bugIssues and PRs for confirmed bugs.Issues and PRs for confirmed bugs.

   on Apr 12, 2018
5. devsnek commented on Apr 12, 2018

   

   devsnek

   on Apr 12, 2018

   Member

   More actions

   i'm still unable to reproduce this 😕
6. BridgeAR commented on Apr 12, 2018

   

   BridgeAR

   on Apr 12, 2018

   Member

   More actions

   How did you try to reproduce this so far?
7. devsnek commented on Apr 12, 2018

   

   devsnek

   on Apr 12, 2018

   Member

   More actions

   I tried your inputs above but got the expected results out.
8. targos commented on Apr 19, 2018

   

   targos

   on Apr 19, 2018

   Last edited by targos

   MemberAuthor

   More actions

   I still have this problem.

   Can you try to reproduce with the following branch?
   https://github.com/targos/node/tree/net-check-family

   $ out/Release/node test/parallel/test-http-localaddress-bind-error.js
   net.js:884
       CHECK((addressType) !== (undefined));
       ^
   
   ReferenceError: CHECK is not defined
       at internalConnect (net.js:884:5)
       at defaultTriggerAsyncIdScope (internal/async_hooks.js:294:19)
       at GetAddrInfoReqWrap.emitLookup [as callback] (net.js:1080:9)
       at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:55:10)
   
9. jasnell commented on Aug 11, 2018

   

   jasnell

   on Aug 11, 2018

   Member

   More actions

   Ping @targos ... is this still an issue for you? I'm unable to reproduce.
10. apapirovski commented on Oct 26, 2018

    

    apapirovski

    on Oct 26, 2018

    Contributor

    More actions

    Given the lack of a follow up, I'm going to close this out. Please feel free to reopen if you believe I've made a mistake and this is still an existing issue.
11. apapirovski

    closed this as completedon Oct 26, 2018