You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@targos@refack while adding a new source for today's V8 upgrade, I noticed that at least one section in v8/unittests.gyp isn't sorted alphabetically. Do you think it's worthwhile to spend some time to sort the entire file? In the future, it will help us place and find sourcepaths easily.
@targos According to @refack (we talked about this in a private conversation):
AFAICT we only use v8.gyp features.gypi, toolset.gypi, inspector.gypi. And in some cases d8.gyp
In that case, I'll try removing all of the others and see if that fails. I think it's unnecessary on our end to maintain all these files if they're literally used nowhere.
Activity
targos commentedon Dec 13, 2018
Is
unittests.gypused by anything in Node?ryzokuken commentedon Dec 13, 2018
@targos According to @refack (we talked about this in a private conversation):
In that case, I'll try removing all of the others and see if that fails. I think it's unnecessary on our end to maintain all these files if they're literally used nowhere.
deps: remove test-related GYP files
deps: remove test-related GYP files
bnoordhuis commentedon Jan 8, 2019
#25097 landed so this can be closed, right? I'm closing it, please reopen if that's a mistake.
deps: remove test-related GYP files