Skip to content

http: ClientRequest might never emit close if has agent and is aborted #28684

Closed
Closed
http: ClientRequest might never emit close if has agent and is aborted#28684
Labels
httpIssues and PRs related to the http subsystem.

Description

@ronag
ronag
opened on Jul 14, 2019

Not sure how to trigger this since I'm not a heavy agent user but looking at the following section:

https://github.com/nodejs/node/blob/master/lib/_http_client.js#L710

If I call abort it looks like only abort might be emitted and close is never.

Activity

  1. ronag commented on Jul 14, 2019

    @ronag
    ronag
    on Jul 14, 2019
    MemberAuthor

    @mcollina ping

  2. lpinca
    added
    httpIssues and PRs related to the http subsystem.
    on Jul 28, 2019
  3. Trott
    added a commit that references this issue on Oct 15, 2019

    http: emit close on socket re-use

    d247a8e

  4. ronag commented on Apr 19, 2020

    @ronag
    ronag
    on Apr 19, 2020
    MemberAuthor

    I believe this has been resolved.

  5. ronag
    closed this as completedon Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    httpIssues and PRs related to the http subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions