Repository navigation
net: pending socket re-use #30832
Description
It looks like net.Socket instances are intended to be re-used however while reading through the code I spot some potential problems:
_destroy(): doesn't wait for connect to finishconnect: doesn't first destroy if already connected, before connecting againconnect: doesn't wait for pending destroy to finish, before calling e.g._undestroy()
Not sure if these are actual problems that need to be fixed?
Activity
[-]net socket re-use[/-][+]net: pending socket re-use[/+]mcollina commentedon Dec 7, 2019
I think those things would ideally need to be fixed, however this is a really obscure feature of Node.js, and I suspect most do not even know that is there or why it's needed. If the fix are trivial, go for them. If they are complex, then it's probably not worth it.
ronag commentedon Dec 7, 2019
I'll look into it when porting it over to
_construct.Would it be an option to hard deprecate re-use and error when trying to do so?
mcollina commentedon Dec 7, 2019
Possibly, I'm not sure if there are some usage in the wild.
ronag commentedon Mar 10, 2020
I find
connectw/ re-use kind of dangerous. Could we doc deprecate, add a runtime warning or something along those lines?github-actions commentedon Jun 27, 2026
This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
github-actions commentedon Jul 28, 2026
This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.