Repository navigation
Conversation
Destroy the connection instead of emitting the upgrade or connect event when an earlier response is still pending. This prevents protocol-switch responses from being written ahead of earlier HTTP responses. Document the behavior and cover both methods with regression tests. Assisted-by: Codex Signed-off-by: Matteo Collina <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66676 +/- ##
==========================================
- Coverage 92.82% 90.47% -2.35%
==========================================
Files 422 791 +369
Lines 194189 277095 +82906
Branches 30027 53278 +23251
==========================================
+ Hits 180249 250696 +70447
- Misses 13614 16810 +3196
- Partials 326 9589 +9263
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destroy the connection instead of emitting the upgrade or connect event when an earlier response is still pending. This prevents protocol-switch responses from being written ahead of earlier HTTP responses.
Document the behavior and cover both methods with regression tests.
—
AI gen, reviewed by me.