Skip to content

quic: allow null body when opening streams - #66690

Open
efekrskl wants to merge 1 commit into
nodejs:mainfrom
efekrskl:quic/stream-null-body
Open

efekrskl wants to merge 1 commit into
nodejs:mainfrom
efekrskl:quic/stream-null-body

Conversation

@efekrskl

Copy link
Copy Markdown
Member

createBidirectionalStream({ body: null }) was documented as valid but is rejected. This PR allows passing null as body which is also supported in setBody and a regression test

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation. labels Oct 12, 2026
@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.47%. Comparing base (a7a96c2) to head (f4a0587).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66690      +/-   ##
==========================================
- Coverage   90.47%   90.47%   -0.01%     
==========================================
  Files         791      791              
  Lines      277088   277089       +1     
  Branches    53286    53279       -7     
==========================================
- Hits       250703   250689      -14     
- Misses      16805    16817      +12     
- Partials     9580     9583       +3     
Files with missing lines Coverage Δ
lib/internal/quic/quic.js 100.00% <100.00%> (ø)

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants