Repository navigation
vfs: route mkdtempDisposable through the fs hooks - #66695
Open
samuelmbabhazi wants to merge 1 commit into
Open
samuelmbabhazi wants to merge 1 commit into
samuelmbabhazi wants to merge 1 commit into
Conversation
fs.mkdtempSync() and fsPromises.mkdtemp() consult the VFS handlers, but fs.mkdtempDisposableSync() and fsPromises.mkdtempDisposable() call the binding directly. On a mounted path they fail with ENOTDIR, because the mount point does not exist on the real file system, while the non-disposable variants succeed. Add the two handlers. They create the directory with the VFS mkdtemp and remove it with the VFS rm, so the disposable object behaves like the real one: the path is a Buffer when the buffer encoding is requested, and remove() can be called more than once. Refs: nodejs#65852 Signed-off-by: Samuel Mbabhazi <[email protected]>
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs.mkdtempDisposableSync()andfsPromises.mkdtempDisposable()bypass the VFS handlers thatfs.mkdtempSync()andfsPromises.mkdtemp()consult, so on a mounted path they fail withENOTDIR(the mount point does not exist on the real file system):This adds the two handlers, built on the VFS
mkdtempandrm, and a test covering the sync and promise variants,Symbol.disposeandSymbol.asyncDispose, the buffer encoding, repeatedremove()calls, and a prefix outside the mount.Verified locally on Linux: the new test, every
test/parallel/test-vfs-*test and the fs mkdtemp tests pass. Same approach as #65852.A coding assistant helped with the investigation and the first draft; I reviewed the change, built Node and ran the tests locally.