Skip to content

Build broken on Windows (VS2017) #128

Closed
Closed
Build broken on Windows (VS2017)#128

Description

@targos
targos
opened on Dec 4, 2019

https://ci.nodejs.org/job/node-compile-windows/30296/nodes=win-vs2017/console

11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::FreeSpace': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\class-definitions-tq.h(107): note: see declaration of 'v8::internal::FreeSpace'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::FreeSpace
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(1224): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::FreeSpace,v8::internal::FreeSpace>' being compiled
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\x64\register-x64.h(153): note: see reference to class template instantiation 'v8::internal::RegisterBase<v8::internal::XMMRegister,16>' being compiled
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\x64\register-x64.h(53): note: see reference to class template instantiation 'v8::internal::RegisterBase<v8::internal::Register,16>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSRegExpStringIterator': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(59): note: see declaration of 'v8::internal::JSRegExpStringIterator'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSRegExpStringIterator
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(1566): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSRegExpStringIterator,v8::internal::JSRegExpStringIterator>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::SyntheticModule': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\heap\factory.h(66): note: see declaration of 'v8::internal::SyntheticModule'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::SyntheticModule
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(2460): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::SyntheticModule,v8::internal::SyntheticModule>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::TemplateObjectDescription': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\heap\factory.h(67): note: see declaration of 'v8::internal::TemplateObjectDescription'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::TemplateObjectDescription
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(2478): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::TemplateObjectDescription,v8::internal::TemplateObjectDescription>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSDateTimeFormat': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(53): note: see declaration of 'v8::internal::JSDateTimeFormat'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSDateTimeFormat
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3066): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSDateTimeFormat,v8::internal::JSDateTimeFormat>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSDisplayNames': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(54): note: see declaration of 'v8::internal::JSDisplayNames'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSDisplayNames
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3102): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSDisplayNames,v8::internal::JSDisplayNames>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSListFormat': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(55): note: see declaration of 'v8::internal::JSListFormat'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSListFormat
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3114): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSListFormat,v8::internal::JSListFormat>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSNumberFormat': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(57): note: see declaration of 'v8::internal::JSNumberFormat'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSNumberFormat
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3132): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSNumberFormat,v8::internal::JSNumberFormat>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSPluralRules': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(58): note: see declaration of 'v8::internal::JSPluralRules'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSPluralRules
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3162): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSPluralRules,v8::internal::JSPluralRules>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSRelativeTimeFormat': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(60): note: see declaration of 'v8::internal::JSRelativeTimeFormat'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSRelativeTimeFormat
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3186): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSRelativeTimeFormat,v8::internal::JSRelativeTimeFormat>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSLocale': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(56): note: see declaration of 'v8::internal::JSLocale'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSLocale
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3210): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSLocale,v8::internal::JSLocale>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSSegmenter': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(62): note: see declaration of 'v8::internal::JSSegmenter'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSSegmenter
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3216): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSSegmenter,v8::internal::JSSegmenter>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSSegmentIterator': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(61): note: see declaration of 'v8::internal::JSSegmentIterator'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSSegmentIterator
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3234): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSSegmentIterator,v8::internal::JSSegmentIterator>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSV8BreakIterator': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(63): note: see declaration of 'v8::internal::JSV8BreakIterator'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSV8BreakIterator
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3252): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSV8BreakIterator,v8::internal::JSV8BreakIterator>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSCollator': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(51): note: see declaration of 'v8::internal::JSCollator'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSCollator
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3306): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSCollator,v8::internal::JSCollator>' being compiled

Activity

  1. targos commented on Dec 10, 2019

    @targos
    targos
    on Dec 10, 2019
    MemberAuthor

    /cc @nodejs/platform-windows

  2. gengjiawen commented on Jan 18, 2020

    @gengjiawen
    gengjiawen
    on Jan 18, 2020
    Member

    Thought on add visual studio 2017 to github action ?

  3. cclauss commented on Jan 18, 2020

    @cclauss
    cclauss
    on Jan 18, 2020

    Both Visual Studio 2017 and 2019 are available on GitHub Actions if you want to take a shot at it.

  4. gengjiawen commented on Jan 18, 2020

    @gengjiawen
    gengjiawen
    on Jan 18, 2020
    Member

    Both Visual Studio 2017 and 2019 are available on GitHub Actions if you want to take a shot at it.

    Yeap. But I want github action only do the least job. We have jenkins for full CI.
    Maybe only add vs2017 to this repo only ? cc @targos @richardlau

  5. targos commented on Jan 18, 2020

    @targos
    targos
    on Jan 18, 2020
    MemberAuthor

    What kind of information could a github action give us that's not already part of our CI job result?

  6. gengjiawen commented on Jan 18, 2020

    @gengjiawen
    gengjiawen
    on Jan 18, 2020
    Member

    What kind of information could a github action give us that's not already part of our CI job result?

    Automatically trigger for PR and push.

    Also the build log won't lost. ci.nodejs.org/job/node-compile-windows/30296/nodes=win-vs2017/console is broken.

    But I am quite insist on this, we got vs2019 on github action anyway.

  7. richardlau commented on Jan 18, 2020

    @richardlau
    richardlau
    on Jan 18, 2020
    Member

    The GitHub runner containing VS2017 is being removed soon:

    Note: The Windows Server 2016 virtual environment will be removed in January 2020.

    https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners#windows-server-2016

  8. richardlau commented on Jan 18, 2020

    @richardlau
    richardlau
    on Jan 18, 2020
    Member

    (Also our Windows builds using GitHub Actions are broken at the moment failing to install nasm.)

  9. gengjiawen commented on Jan 18, 2020

    @gengjiawen
    gengjiawen
    on Jan 18, 2020
    Member

    (Also our Windows builds using GitHub Actions are broken at the moment failing to install nasm.)

    Yeap, there websites is down.

  10. gengjiawen commented on Jan 18, 2020

    @gengjiawen
    gengjiawen
    on Jan 18, 2020
    Member

    Looks like this happen multi times microsoft/vcpkg#2777

  11. gengjiawen commented on Feb 26, 2020

    @gengjiawen
    gengjiawen
    on Feb 26, 2020
    Member

    current error on visual studio 2017:

    [00:41:30] objects-printer-tq.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] class-verifiers-tq.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] simulator-base.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] perf-jit.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] objects-debug.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] gdb-jit.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] tnode.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] constant-pool.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:31]   v8_base_without_compiler.vcxproj -> ..\..\out\Release\lib\v8_base_without_compiler.lib

  12. gengjiawen commented on Feb 27, 2020

    @gengjiawen
    gengjiawen
    on Feb 27, 2020
    Member

    New fix: #143.

  13. targos
    closed this as completedon Feb 27, 2020
  14. pull
    added a commit that references this issue on Mar 11, 2020

    [torque] fix build on VS2017

    931bdbd
  15. nodejs-ci
    added 2 commits that reference this issue on Mar 12, 2020

    deps: V8: cherry-pick 931bdbd76f5b

    dc0be7f

    deps: V8: cherry-pick 931bdbd76f5b

    5ea71eb
  16. nodejs-ci
    added 2 commits that reference this issue on Mar 14, 2020

    deps: V8: cherry-pick 931bdbd76f5b

    cc3a75f

    deps: V8: cherry-pick 931bdbd76f5b

    ec34d45
  17. mmarchini
    added 2 commits that reference this issue on Mar 16, 2020

    deps: V8: cherry-pick 931bdbd76f5b

    04e0e67

    deps: V8: cherry-pick 931bdbd76f5b

    2e73c79
  18. nodejs-ci
    added 3 commits that reference this issue on Mar 16, 2020

    deps: V8: cherry-pick 931bdbd76f5b

    8503828

    deps: V8: cherry-pick 931bdbd76f5b

    f770a65

    deps: V8: cherry-pick 931bdbd76f5b

    5b90512
  19. mmarchini
    added a commit that references this issue on Mar 18, 2020

    deps: V8: cherry-pick 931bdbd76f5b

    8d2c441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions