Skip to content

fix: run node tests on merge - #2707

Merged
mcollina merged 1 commit into
nodejs:mainfrom
Uzlopak:run-tests-on-merge-on-main
Feb 6, 2024
Merged

mcollina merged 1 commit into
nodejs:mainfrom
Uzlopak:run-tests-on-merge-on-main

Conversation

@Uzlopak

@Uzlopak Uzlopak commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

@mcollina

This change ensures that the node tests run when a pr gets merged into main.

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@codecov-commenter

ghost commented Feb 6, 2024 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.28%. Comparing base (e39a632) to head (df96b9b).
⚠️ Report is 1508 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2707      +/-   ##
==========================================
- Coverage   85.54%   85.28%   -0.27%     
==========================================
  Files          76       84       +8     
  Lines        6858     7584     +726     
==========================================
+ Hits         5867     6468     +601     
- Misses        991     1116     +125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina

ghost commented Feb 6, 2024

Copy link
Copy Markdown
Member

thx

@mcollina
mcollina merged commit e48df96 into nodejs:main Feb 6, 2024
@Uzlopak
Uzlopak deleted the run-tests-on-merge-on-main branch February 6, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants