Skip to content

Feature/themes - #22

Merged
nore-dev merged 5 commits into
nore-dev:mainfrom
dzzzchhh:feature/Themes
Oct 5, 2022
Merged

nore-dev merged 5 commits into
nore-dev:mainfrom
dzzzchhh:feature/Themes

Conversation

@dzzzchhh

@dzzzchhh dzzzchhh commented Oct 5, 2022 •

Copy link
Copy Markdown
Contributor

Topic

Proposal for handling themes.

Notable changes

  • Introduces CLI arguments handling with help of go-arg
  • Adds a brogrammer theme option (in its current state it only resembles the brogrammer palette, I added it to showcase the ability of switching between themes)
  • If no --theme option is provided then default theme is picked and displayed.

Other changes

  • Sorry for removing the updatePath function in main.go - it was the only way to make CLI arguments work and not break the filepaths. Everything seems to work properly, but please do tell if I made a mistake by removing it, I'm not too efficient with bubbletea.

Closes #21

fman_themes.mp4

@nore-dev nore-dev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dzzzchhh

Comment thread main.go
Comment thread theme/config.go Outdated
Comment thread main.go
@dzzzchhh
dzzzchhh requested a review from nore-dev October 5, 2022 18:51
Comment thread main.go Outdated
@nore-dev
nore-dev merged commit 70bcb25 into nore-dev:main Oct 5, 2022
@nore-dev

nore-dev commented Oct 5, 2022

Copy link
Copy Markdown
Owner

thank you again @dzzzchhh

@nore-dev

nore-dev commented Oct 5, 2022

Copy link
Copy Markdown
Owner

i forgot to squash again

@dzzzchhh
dzzzchhh deleted the feature/Themes branch October 5, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Themes

2 participants