Repository navigation
Deprecation issues in tests with too-new setuptools versions #24350
Description
There are two deprecation issues when running python -mspin test with Python 3.11:
sre_constantsandsre_parseare deprecated. This breaks test collection but can by fixed
by using recent setuptools.pkg_resourcesis deprecated in recent setuptools, this causesnumpy/distutils/tests/test_system_info.py
to fail
Note that we have several other uses of pkg_resources
- In
tools/npy_tempita/__init__.py In numpy/_utils/_pep440.py (copied from SciPy)- In
versioneer.py(going away)
We should fix the usage in the first file.
The easiest quick solution is to upgrade the setuptools version requirement and ignore the test_system_info error.
Activity
charris commentedon Aug 6, 2023
We don't use the troublesome parts of tempita, and in fact they don't run :) The version in Cython is no better in that regard. Maybe be can just get rid of much of it.
EDIT: The pkg_resources bit can be removed, our version is not distributed as a package. Or we could just hardwire it to '3.5.2'
charris commentedon Aug 7, 2023
We should probably just skip testing
numpy/distutilssince we need to use a recent version of setuptools to avoid other deprecations. We could, I suppose, make the tests version dependent.rgommers commentedon Aug 7, 2023
Skipping the problematic tests in
numpy.distutilswhen thesetuptoolsversion is >= 60.0 on Python 3.11 sounds right to me. That's what we already required.[-]Deprecation issues with meson builds[/-][+]Deprecation issues in tests with too-new setuptools versions[/+]rgommers commentedon Aug 7, 2023
tools/npy_tempita/__init__.pyis only used in thenumpy.distutilsbuild, so it's going away - no need to worry about that one. I'll open a PR to make thenumpy.distutilstests pass.TST: fix distutils tests for deprecations in recent setuptools versions
TST: fix distutils tests for deprecations in recent setuptools versions
charris commentedon Aug 7, 2023
@rgommers
We have setuptools pinned in various ways in several locations
I'm wondering if we should change those pins? That essentially locks us into meson builds, but I think that is already the case.
rgommers commentedon Aug 7, 2023
I'd much prefer not to touch them right now. Most of that is still needed. We should be able to get rid of all them in a few months.
TST: fix distutils tests for deprecations in recent setuptools versions