Skip to content

LICENSES_bundled.txt content not included in license file for wheels in 1.26.0 #24764

Closed

Description

@rgommers

I noticed this when reviewing gh-24753. I thought this was taken care of in the wheel build scripts, however that is a different kind of concatenation (for the vendored shared libraries, libopenblas & co):

# Update license
if [[ $RUNNER_OS == "Linux" ]] ; then
    cat $PROJECT_DIR/tools/wheels/LICENSE_linux.txt >> $PROJECT_DIR/LICENSE.txt
elif [[ $RUNNER_OS == "macOS" ]]; then
    cat $PROJECT_DIR/tools/wheels/LICENSE_osx.txt >> $PROJECT_DIR/LICENSE.txt
elif [[ $RUNNER_OS == "Windows" ]]; then
    cat $PROJECT_DIR/tools/wheels/LICENSE_win32.txt >> $PROJECT_DIR/LICENSE.txt
fi

When PEP 639 finally arrives we get a license-files field that allows listing multiple license files in metadata. But for now we need to continue concatenation these files together for the wheels we distribute. I'll open a PR to fix this.

Activity

  1. added this to the 1.26.1 release milestone on Sep 21, 2023
  2. added a commit that references this issue on Sep 21, 2023
    ece2920
  3. mattip commented on Sep 21, 2023

    @mattip
    Member

    The LICENSE_bundled.txt refers to licenses like numpy/linalg/lapack_litee/LICENCES.txt that it seems are not included in the 1.26 meson-produced wheel. Maybe the text should include a link to the numpy repo with a text like "at the appropriate tag"?

  4. added a commit that references this issue on Sep 21, 2023
    6d8db6c
  5. added 2 commits that reference this issue on Sep 23, 2023
    1564b42
    e6a9786
  6. added a commit that references this issue on Nov 11, 2023
    a7315a3
  7. added a commit that references this issue on Jan 27, 2024
    085665c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions