You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
LICENSES_bundled.txt content not included in license file for wheels in 1.26.0 #24764
I noticed this when reviewing gh-24753. I thought this was taken care of in the wheel build scripts, however that is a different kind of concatenation (for the vendored shared libraries, libopenblas & co):
# Update license
if [[ $RUNNER_OS == "Linux" ]] ; then
cat $PROJECT_DIR/tools/wheels/LICENSE_linux.txt >> $PROJECT_DIR/LICENSE.txt
elif [[ $RUNNER_OS == "macOS" ]]; then
cat $PROJECT_DIR/tools/wheels/LICENSE_osx.txt >> $PROJECT_DIR/LICENSE.txt
elif [[ $RUNNER_OS == "Windows" ]]; then
cat $PROJECT_DIR/tools/wheels/LICENSE_win32.txt >> $PROJECT_DIR/LICENSE.txt
fi
When PEP 639 finally arrives we get a license-files field that allows listing multiple license files in metadata. But for now we need to continue concatenation these files together for the wheels we distribute. I'll open a PR to fix this.
The LICENSE_bundled.txt refers to licenses like numpy/linalg/lapack_litee/LICENCES.txt that it seems are not included in the 1.26 meson-produced wheel. Maybe the text should include a link to the numpy repo with a text like "at the appropriate tag"?
Activity
REL: fix license concatenation for wheels we distribute [wheel build]
mattip commentedon Sep 21, 2023
The
LICENSE_bundled.txtrefers to licenses likenumpy/linalg/lapack_litee/LICENCES.txtthat it seems are not included in the 1.26 meson-produced wheel. Maybe the text should include a link to the numpy repo with a text like "at the appropriate tag"?REL: fix license concatenation for wheels we distribute [wheel build]
BLD: add libquadmath to licences and other tweaks (numpy#24753)
BLD: add libquadmath to licences and other tweaks (numpy#24753)
BLD: add libquadmath to licences and other tweaks (numpy#24753)
BLD: add libquadmath to licences and other tweaks (numpy#24753)