Skip to content

DOC: install from git instructions should mention submodules initialization #25132

Description

@ngoldbaum

Especially for people who only build numpy from source occasionally, I think it would be helpful to add the git submodule init step to the current dev INSTALL.rst and "Install from source" instructions (https://numpy.org/devdocs/user/building.html#basic-installation).

I was also confused by this error message and it was only after trying to build with spin that I got more a helpful error message. The meson-python requirement at the top of pyproject.toml looks straight-forward at first glance and the vendored-meson/... lines are quite buried in the details. And no amount of verbose pip really helps you figure out what's going on.

Originally posted by @adrianeboyd in #25084 (comment)

Activity

  1. changed the title [-]Especially for people who only build numpy from source occasionally, I think it would be helpful to add this step to the current dev `INSTALL.rst` and "Install from source" instructions (https://numpy.org/devdocs/user/building.html#basic-installation).[/-] [+]DOC: install from git instructions should mention submodules initialization[/+] on Nov 13, 2023
  2. jorisvandenbossche commented on Nov 15, 2023

    @jorisvandenbossche
    Contributor

    I also just ran into this: I had an older numpy clone, which I updated with git pull (which doesn't update the submodules), and tried to install the latest main with pip install. I have to say this is a quite confusing error message ;) (because I did have meson installed, and it was a more recent version)

    It's especially confusing because the message you get is "meson-python: error: Could not find meson version 0.63.3 or newer, found .", which is not using the custom "1.2.99" version of the vendored meson.

    But I assume it's beyond numpy's control to customize that message? (since it's coming from meson-python)

  3. adrianeboyd commented on Nov 17, 2023

    @adrianeboyd

    Thanks for updating this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions