Skip to content

Color and font choice for typesetting inline code - drop the pink/red #25927

Closed

Description

@rgommers

After spending a fair bit of time staring at the 2.0.0 release notes, the use of the bright red/pink color and the too-large font for text that is typeset as inline code became really jarring.

image

Compare with the docs of pydata-sphinx-theme itself:

image

That is far more pleasant to read. The theme authors have spent a lot of time polishing these choices; our bright pink/red is a leftover from the initial theme (originally from Pandas).

Proposal: switch color choices and font sizes to the theme defaults.

Activity

  1. rgommers commented on Mar 4, 2024

    @rgommers
    MemberAuthor

    Got some info: we need at least 0.14.0 for the color changes (we currently have it pinned at 0.13.3), and scipy/scipy#19958 is a similar issue for SciPy that touches on some issues that the NumPy docs are also going to have (being worked on).

    Upgrading to the latest version (0.15.2) locally gives the more muted colors, and deleting doc/source/_static/numpy.css files the font size problem. There are some other rendering issues, but the colors/fonts look way better:

    image
  2. seberg commented on May 6, 2024

    @seberg
    Member

    The sphinx theme has been bumped on main, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions