Skip to content

BUG: Changes to core/ufunc_docstrings are ignored in incremental builds #9046

Description

@eric-wieser

The contents of this file is loaded at generation-time into generate_umath.py. Unfortunately, the condition for regenerating the c code is not dependent on whether this file has changed

Activity

  1. changed the title [-]BUG: Changes to `ufunc_docstrings` are ignored in incremental builds[/-] [+]BUG: Changes to core/ufunc_docstrings are ignored in incremental builds[/+] on May 3, 2017
  2. rgommers commented on Sep 16, 2023

    @rgommers
    Member

    This rebuild seems to be done correctly now after the switch to Meson:

    $ spin build
    $ spin build
    ....
    [1/1] Generating numpy/generate-version with a custom command
    
    $ touch numpy/core/code_generators/generate_umath.py
    $ spin build
    ...
    [5/5] Linking target numpy/core/_multiarray_umath.cpython-39-darwin.so
    

    Nice to have a good build system:) It's not impossible there's still missing links, but we have a check with ninja -C build -t missingdeps and it should be correct for everything ninja knows about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions