Repository navigation
Conversation
Comparison was based on using operator.eq and operator.ne on the underlying arrays. This goes wrong, however, if one of those does not know how to deal properly with the other - as was exposed by astropy issue astropy/astropy#6838.
Contributor
Author
|
@charris - actually - am not sure this is the correct approach. So, just ignore for now; it is definitely a corner case. |
Contributor
Author
|
Now quite sure the current code is fine, or at least more correct than this one, so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparison was based on using operator.eq and operator.ne on the underlying arrays. This goes wrong, however, if one of those does not know how to deal properly with the other - as was exposed by astropy issue astropy/astropy#6838.
@charris - is there any hope to still have this in 1.14?
p.s. I somewhat on purpose made the somewhat ugly
lambdadefinitions in__eq__and__ne__as I didn't want to gratuitously change the API of_compare. It's easy to change it to just passing on the string.