Skip to content

MAINT: Remove np.pkgload, which seems to be unusable anyway - #11703

Merged
charris merged 1 commit into
numpy:masterfrom
eric-wieser:remove-_import_tools
Aug 12, 2018
Merged

charris merged 1 commit into
numpy:masterfrom
eric-wieser:remove-_import_tools

Conversation

@eric-wieser

Copy link
Copy Markdown
Member

Attempts to use this on either cpython27 or cpython35, in either a shell or a script, gives:

NameError: name '__path__' is not defined

Comment thread numpy/_import_tools.py Outdated

@eric-wieser eric-wieser Aug 10, 2018 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't even spot this. > 3ish years seems like plenty of time to wait, especially since it seems we broke it anyway

@charris

charris commented Aug 12, 2018

Copy link
Copy Markdown
Member

Needs a release note, otherwise LGTM.

Attempts to use this on either cpython27 or cpython35, in either a shell or a script, gives:

    NameError: name '__path__' is not defined

Perhaps I'm calling it wrong, but it might just be broken.
@eric-wieser
eric-wieser force-pushed the remove-_import_tools branch from ae16dac to 85cf4ef Compare August 12, 2018 17:49
@eric-wieser

Copy link
Copy Markdown
Member Author

Updated

@charris

charris commented Aug 12, 2018

Copy link
Copy Markdown
Member

Thanks Eric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants