Repository navigation
MAINT: Fixups to new functions in np.lib.recfunctions - #12446
Merged
Merged
Conversation
eric-wieser
reviewed
Nov 24, 2018
ahaldane
force-pushed
the
recfunctions_fixups
branch
from
November 24, 2018 23:41
067b6a6 to
bf8fb6f
Compare
eric-wieser
reviewed
Nov 25, 2018
eric-wieser
approved these changes
Nov 25, 2018
ahaldane
force-pushed
the
recfunctions_fixups
branch
5 times, most recently
from
November 25, 2018 20:46
0f6e722 to
143c60e
Compare
Member
|
CI fails with: AssertionError: ignore filter should not be used; found in /numpy/build/testenv/lib/python3.6/site-packages/numpy/lib/recfunctions.py on line 970 |
ahaldane
force-pushed
the
recfunctions_fixups
branch
from
November 26, 2018 18:03
143c60e to
191d5c7
Compare
Member
Author
|
Ignore-filter issue fixed. |
Member
|
Thanks Allan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #11526 fixing up a few issues with that PR.