Skip to content

TST: Fix endianness in unstuctured_to_structured test - #12671

Merged
charris merged 1 commit into
numpy:masterfrom
ahaldane:fix_us_to_s_tst
Jan 5, 2019
Merged

charris merged 1 commit into
numpy:masterfrom
ahaldane:fix_us_to_s_tst

Conversation

@ahaldane

@ahaldane ahaldane commented Jan 5, 2019

Copy link
Copy Markdown
Member

Fixes one of the three failing SPARC tests in #12638.

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that these < were inserted in the first place. In any case, the fix is logical and looks good.

@ahaldane

ahaldane commented Jan 5, 2019

Copy link
Copy Markdown
Member Author

I wrote that test not too long ago :) Probably it was a cut-n-paste mistake.

@charris

charris commented Jan 5, 2019

Copy link
Copy Markdown
Member

The azure failure was the same sporadic InvalidValue error we have seen before on Python 3.7. I think something has changed in error suppression and is comes from elsewhere than the test in which it appears.

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Jan 5, 2019
@charris charris added this to the 1.16.0 release milestone Jan 5, 2019
@charris

charris commented Jan 5, 2019

Copy link
Copy Markdown
Member

I may kick these fixes off to 1.16.1, but this one looks pretty safe.

@charris
charris merged commit 8ead96c into numpy:master Jan 5, 2019
@charris

charris commented Jan 5, 2019

Copy link
Copy Markdown
Member

Thanks Allan.

@DerDakon

DerDakon commented Jan 5, 2019

Copy link
Copy Markdown

I'm running a test with this on sparc, but it will take a while.

@ahaldane

ahaldane commented Jan 5, 2019

Copy link
Copy Markdown
Member Author

Incidentally, I ran the test suite for the maintenance/1.16.x branch on ppc64be, with and without USE_DEBUG.

Without USE_DEBUG, this is the only test that fails.

With USE_DEBUG, I am getting uint alignment issues like in #12626. I'm investigating.

@DerDakon

DerDakon commented Jan 5, 2019

Copy link
Copy Markdown

I suggest running a build with -Wcast-align. I can send you my sparc log, but it's a bit large.

@ahaldane

ahaldane commented Jan 5, 2019

Copy link
Copy Markdown
Member Author

OK, I found a stupid typo in #12626. I'll try cast-align soon.

@DerDakon DerDakon mentioned this pull request Jan 5, 2019
2 of 4 tasks
@DerDakon

DerDakon commented Jan 5, 2019

Copy link
Copy Markdown

Seems to help.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jan 9, 2019
@charris charris removed this from the 1.16.0 release milestone Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants