Repository navigation
MAINT: remove duplicated if statements between DescrConverters - #15266
Merged
Merged
Conversation
Member
Author
|
The CI failure here baffles me - they only seem to happen on azure, and linux: https://dev.azure.com/numpy/numpy/_build/results?buildId=7317&view=results |
eric-wieser
force-pushed
the
deduplicate-if-align
branch
from
January 6, 2020 22:51
7649f27 to
8668016
Compare
seberg
reviewed
Jan 6, 2020
eric-wieser
force-pushed
the
deduplicate-if-align
branch
from
January 6, 2020 23:34
8668016 to
e116fbb
Compare
eric-wieser
force-pushed
the
deduplicate-if-align
branch
from
January 7, 2020 00:19
e116fbb to
d11601b
Compare
eric-wieser
commented
Jan 7, 2020
| for (i = 0; i < n; i++) { | ||
| PyObject *tup, *descr, *ind, *title, *name, *off; | ||
| int len, ret, _align = 1; | ||
| int len, _align = 1; |
Member
Author
There was a problem hiding this comment.
Mystery solved, this ret was being used uninitialized further down the file, in places where it made no sense to check it anyway.
Member
There was a problem hiding this comment.
Odd that the compiler warning tests did not find that :(.
Member
Author
There was a problem hiding this comment.
Well, there was a codepath that set it, so the error was likely something like "maybe uninitialized", rather than "is uninitialized".
Member
|
Ok, the shippable test does not matter, and it looks good to me now. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #15265, since that failed in a peculiar way in only non-windows CI, and submitting this commit separately will allow me to bisect.