Repository navigation
BUG: Fix PyArray_DescrAlignConverter2 on tuples - #15267
Merged
seberg merged 1 commit intoJan 7, 2020
Merged
Conversation
The previous implementation of `PyArray_DescrAlignConverter2` did not match `PyArray_DescrAlignConverter`, and only the latter would actually apply the alignment flag to union types. What happened here is that `ab9953baf29ace44ef1f014f3713f1ee919f79bb` fixed union types for `PyArray_DescrAlignConverter` but forgot to apply the same fix for `PyArray_DescrAlignConverter2` . Expressing one in terms of the other makes this problem go away. Numpy has no internal callers of PyArray_DescrAlignConverter2.
Member
|
LGTM, can we use the test from gh-10923 to include a function that uses the |
Member
Author
Are you suggesting I add a new function to test_multiarray? There are no existing callers of this converter to be tested, and I'd perhaps argue that the 5 or so lines of code left in this function aren't interesting enough to bother with writing a c-side test. |
Member
|
Yeah, I thought someone would be calling it indirectly, but I guess that is not possible, since you cannot pass the aligned flag to any of the functions except |
Member
Author
|
Only 4 occurences of the symbol in our entire codebase, all only definitions: |
Member
|
Thanks Eric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation of
PyArray_DescrAlignConverter2did not matchPyArray_DescrAlignConverter, and only the latter would actually apply the alignment flag tounionsubarray types.What happened here is that ab9953b (#10923) fixed union types for
PyArray_DescrAlignConverterbut forgot to apply the same fix forPyArray_DescrAlignConverter2.Expressing one in terms of the other makes this problem go away.
Numpy has no internal callers of PyArray_DescrAlignConverter2.
Split from #15265, since that failed in a peculiar way in only non-windows CI, and submitting this commit separately will allow me to bisect.