Repository navigation
BUG: Add missing error handling to _convert_from_list - #15291
Merged
mattip merged 1 commit intoJan 10, 2020
Merged
Conversation
Previously this function would return null without setting an exception. Additionally, there were many places it could segfault if an exception occurred.
Member
|
Is there a test we could add that hits some of these code paths? |
Member
|
I do not really think so, none of these should ever fail, unless in low memory situations or so? |
eric-wieser
commented
Jan 10, 2020
| } | ||
| /* End ignore code.*/ | ||
| if (n == 0) { | ||
| PyErr_SetString(PyExc_ValueError, "Expected at least one field name"); |
Member
Author
There was a problem hiding this comment.
This is probably the only testable path, and I'm not sure it's worth the effort.
Member
|
By visual inspection this seems right. We may want to add a custom allocator that can be told to fail via an external parameter (an environment variable or so) that would check all these untested code paths. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this function would return null without setting an exception.
Additionally, there were many places it could segfault if an exception occurred.