Repository navigation
ENH: Fix exception causes in build_ext.py - #16042
Merged
Merged
Conversation
eric-wieser
approved these changes
Apr 22, 2020
eric-wieser
left a comment
eric-wieser
left a comment
Member
There was a problem hiding this comment.
It would be better if you could combine a bunch of these changes into a single PR
Contributor
Author
|
@eric-wieser thank you for review, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this solution is related to the following issue #15986
@eric-wieser can you review this pr?
Thank you.