Repository navigation
ENH: Chain exception in memmap.py - #16060
Closed
ChrisAHolland wants to merge 1 commit into
Closed
ChrisAHolland wants to merge 1 commit into
ChrisAHolland wants to merge 1 commit into
Conversation
Member
|
Did you mean to close this? |
Contributor
Author
|
@eric-wieser I saw that it didn't pass some of the CI tests so I made the impulsive decision to close it and take a further look. I will open another PR to fix this! |
Member
|
There's now a "make draft button" to the right that is a good way to mark PRs as not ready for review just yet, if you change your mind after submitting them. |
Contributor
Author
Thanks for the info! I reopened this PR and added another chained exception in #16067 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This edit is relation to issue #15986.
Only contains 1 exception edit for ease of maintainer review.
@eric-wieser