Repository navigation
MAINT: Chain exceptions in several places. - #16064
Merged
Merged
Conversation
eric-wieser
reviewed
Apr 24, 2020
eric-wieser
reviewed
Apr 24, 2020
keremh
force-pushed
the
fix-exception-raise
branch
from
April 24, 2020 11:33
15bec23 to
ddf0191
Compare
eric-wieser
approved these changes
Apr 24, 2020
rossbar
reviewed
Apr 24, 2020
rossbar
left a comment
rossbar
left a comment
Contributor
There was a problem hiding this comment.
A couple style nits re: line char limits
Co-Authored-By: Ross Barnowski <[email protected]>
Co-Authored-By: Ross Barnowski <[email protected]>
Contributor
Author
|
@rossbar thank you for your suggestions, |
charris
changed the title
charris
added
03 - Maintenance
component: numpy.lib
01 - Enhancement
and removed
03 - Maintenance
01 - Enhancement
labels
charris
changed the title
Member
|
Thanks @keremh . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this solution is related to the following issue #15986
@eric-wieser can you review this pr?
Thank you.