Skip to content

MAINT: Chain exceptions in several places - #16121

Merged
seberg merged 4 commits into
numpy:masterfrom
keremh:fix-exception-raise
Jun 30, 2020
Merged

seberg merged 4 commits into
numpy:masterfrom
keremh:fix-exception-raise

Conversation

@keremh

@keremh keremh commented Apr 30, 2020

Copy link
Copy Markdown
Contributor

this solution is related to the following issue #15986
@eric-wieser can you review this pr?
Thank you.

Comment thread numpy/lib/tests/test_regression.py Outdated
Comment thread numpy/core/tests/test_indexing.py Outdated
@rossbar

rossbar commented May 13, 2020

Copy link
Copy Markdown
Contributor

@keremh - a gentle ping to see if you are still interested in pursuing these changes. It looks all that remains is to address comments about changing the tests then this should be ready for re-review. Note the CI failure is unrelated.

@rossbar
rossbar force-pushed the fix-exception-raise branch from 6ae57dd to f9a1d03 Compare June 29, 2020 23:35
@rossbar

rossbar commented Jun 29, 2020

Copy link
Copy Markdown
Contributor

This PR seemed to have gotten stuck on some merge conflicts following #16633, so I went ahead and rebased on master to try to get everything back to a reviewable state. I also took the liberty of incorporating the bit of feedback from previous reviews about not modifying the handling of exceptions in the tests.

I did notice one last thing: it seems strange that loadtxt and genfromtxt raise different classes of exception in very similar scenarios... but I don't want to overload this PR too much - we'll see if maybe @eric-wieser or @seberg can give it a final once-over then we can get this in.

@seberg

seberg commented Jun 30, 2020

Copy link
Copy Markdown
Member

Looks good to me, thanks everyone.

@seberg
seberg merged commit f38073b into numpy:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants