Repository navigation
MAINT: Chain exceptions in several places - #16121
Conversation
c4ffbc1 to
4491f42
Compare
|
@keremh - a gentle ping to see if you are still interested in pursuing these changes. It looks all that remains is to address comments about changing the tests then this should be ready for re-review. Note the CI failure is unrelated. |
6ae57dd to
f9a1d03
Compare
|
This PR seemed to have gotten stuck on some merge conflicts following #16633, so I went ahead and rebased on master to try to get everything back to a reviewable state. I also took the liberty of incorporating the bit of feedback from previous reviews about not modifying the handling of exceptions in the tests. I did notice one last thing: it seems strange that |
|
Looks good to me, thanks everyone. |
this solution is related to the following issue #15986
@eric-wieser can you review this pr?
Thank you.