Repository navigation
MAINT: Chain some exceptions. - #16418
Conversation
|
Thanks for the patch! Everything looks great with the PR, just looks like I was unclear about how to choose between the two options in the tracking issue. |
charris
changed the title
charris
changed the title
charris
changed the title
numpy.ctypes and numpy.core
charris
changed the title
numpy.ctypes and numpy.core
rossbar
left a comment
rossbar
left a comment
There was a problem hiding this comment.
Just a style nit. It might also be nice to convert the strings in AttributeErrors in numpy/core/records.py to f-strings (this might get the one suggestion below the line limit on its own) or to use .format, but it's not necessary.
Co-authored-by: Ross Barnowski <[email protected]>
|
Ok, I've implemented the feedback I've gotten. I also found some other places where I could fix the exceptions like this, should I just wait for this to be merged or should I keep working on this branch? |
rossbar
left a comment
rossbar
left a comment
There was a problem hiding this comment.
LGTM - I'd say hold off on new modifications (i.e. adding more chained exceptions) so the review doesn't get too muddled.
|
Thanks @zaak71 |
6 participants
This is related to issue #15986. I have modified a few files in the numpy and numpy/core folders to fit what has been requested here. This is my first PR on GitHub so if I did anything wrong please let me know. Thank you.