Repository navigation
MAINT: Chaining exceptions in numpy/core/_internal.py - #16747
Merged
Merged
Conversation
- updated %formatted string to f strings
eric-wieser
reviewed
Jul 4, 2020
| raise ValueError(f"duplicate field name: {name}") from e | ||
| else: | ||
| raise ValueError("unknown field name: %s" % (name,)) | ||
| raise ValueError(f"unknown field name: {name}") from e |
Member
There was a problem hiding this comment.
These two should be from None
eric-wieser
reviewed
Jul 4, 2020
| except (TypeError, AttributeError) as e: | ||
| raise ValueError( | ||
| f'format number {len(result)+1} of "{astr}" is not recognized' | ||
| ) from e |
Member
There was a problem hiding this comment.
Also should be from None, the error here isn't interesting
Contributor
Author
There was a problem hiding this comment.
@eric-wieser I will make the necessary corrections.
- chaining exceptions from None
Member
|
LGTM, thanks @abhinav-thimma and Eric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes related to #15986