Repository navigation
MAINT: Tidy exception chaining in _datasource.py - #16761
Merged
Merged
Conversation
charris
changed the title
eric-wieser
reviewed
Jul 6, 2020
| shutil.copyfileobj(openedurl, f) | ||
| except URLError: | ||
| raise URLError("URL not found: %s" % path) | ||
| except URLError as e: |
Member
There was a problem hiding this comment.
Can you show what the resulting error message is with this change?
Contributor
Author
There was a problem hiding this comment.
- @eric-wieser Before invalid URL exeption ( I run this on my personal conda environment ) was
Traceback (most recent call last):
File "/home/sarthak/anaconda3/lib/python3.7/site-packages/numpy/lib/_datasource.py", line 418, in _cache
with closing(urlopen(path)) as openedurl:
File "/home/sarthak/anaconda3/lib/python3.7/urllib/request.py", line 222, in urlopen
return opener.open(url, data, timeout)
File "/home/sarthak/anaconda3/lib/python3.7/urllib/request.py", line 531, in open
response = meth(req, response)
File "/home/sarthak/anaconda3/lib/python3.7/urllib/request.py", line 641, in http_response
'http', request, response, code, msg, hdrs)
File "/home/sarthak/anaconda3/lib/python3.7/urllib/request.py", line 569, in error
return self._call_chain(*args)
File "/home/sarthak/anaconda3/lib/python3.7/urllib/request.py", line 503, in _call_chain
result = func(*args)
File "/home/sarthak/anaconda3/lib/python3.7/urllib/request.py", line 649, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/sarthak/anaconda3/lib/python3.7/site-packages/numpy/lib/_datasource.py", line 422, in _cache
raise URLError("URL not found: %s" % path)
urllib.error.URLError: <urlopen error URL not found: https://raw.githubusercontent.com/numpy/numpy/master/toxsadas.ini>
- After the change
Traceback (most recent call last):
File "/home/sarthak/Desktop/projects/numpy/numpy/lib/_datasource.py", line 337, in _cache
with closing(urlopen(path)) as openedurl:
File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
return opener.open(url, data, timeout)
File "/usr/lib/python3.8/urllib/request.py", line 531, in open
response = meth(req, response)
File "/usr/lib/python3.8/urllib/request.py", line 640, in http_response
response = self.parent.error(
File "/usr/lib/python3.8/urllib/request.py", line 569, in error
return self._call_chain(*args)
File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain
result = func(*args)
File "/usr/lib/python3.8/urllib/request.py", line 649, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/sarthak/Desktop/projects/numpy/numpy/lib/_datasource.py", line 341, in _cache
raise URLError("URL not found: %s" % path) from e
urllib.error.URLError: <urlopen error URL not found: https://raw.githubusercontent.com/numpy/numpy/master/toxsadas.ini>
eric-wieser
approved these changes
Jul 6, 2020
eric-wieser
left a comment
eric-wieser
left a comment
Member
There was a problem hiding this comment.
Definitely an improvement, but I wonder if we just want to use the inner exception by itself, and remove the try/except. Something for a follow-up PR, perhaps.
Contributor
Author
@eric-wieser Correct me if i am wrong 😕 , the error should look something like ( after removing try/except) |
eric-wieser
approved these changes
Jul 7, 2020
eric-wieser
left a comment
eric-wieser
left a comment
Member
There was a problem hiding this comment.
Great, thanks - looking back at the history, it looks like the second error message was around forever (0ce4792) and probably wasn't very deliberate.
eric-wieser
reviewed
Jul 7, 2020
| shutil.copyfileobj(openedurl, f) | ||
| except URLError: | ||
| raise URLError("URL not found: %s" % path) | ||
| with closing(urlopen(path)) as openedurl: |
Member
There was a problem hiding this comment.
I bet closing isn't needed any more either...
Contributor
Author
There was a problem hiding this comment.
Yes, making another commit also removing from contextlib import closing it is not used anywhere else
Thank you
eric-wieser
reviewed
Jul 8, 2020
| shutil.copyfileobj(openedurl, f) | ||
| except URLError: | ||
| raise URLError("URL not found: %s" % path) | ||
| openedurl = urlopen(path) |
Member
There was a problem hiding this comment.
The with statement is still needed, even if closing is not.
eric-wieser
approved these changes
Jul 8, 2020
eric-wieser
changed the title
Contributor
|
Thanks @sarthakchaudhary13 and @eric-wieser for the review! |
Contributor
Author
|
@eric-wieser and @rossbar thanks for helping me making my first contribution in numpy I am hoping to do more 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this solution is related to the following issue #15986
@eric-wieser this is my first contribution, can you review this pr?
Thank you.