Skip to content

BUG: fix the search dir of dispatch-able sources - #16858

Merged
mattip merged 1 commit into
numpy:masterfrom
seiko2plus:ccopt_fix_inc_tmp_dir
Jul 14, 2020
Merged

mattip merged 1 commit into
numpy:masterfrom
seiko2plus:ccopt_fix_inc_tmp_dir

Conversation

@seiko2plus

Copy link
Copy Markdown
Member

Fix the search dir of dispatch-able sources to allow including the
generated config headers within the dispatch-able sources.

@mattip

mattip commented Jul 14, 2020

Copy link
Copy Markdown
Member

I think the CircleCI failures would be fixed if this picked up gh-16857, since the Azure builds succeed. Could you just confirm that this changeset does not include gh-16857? No need to rebase, I am happy to merge without rebasing.

  to allow including the generated config headers within the dispatch-able sources.
@seiko2plus
seiko2plus force-pushed the ccopt_fix_inc_tmp_dir branch from b71668a to 7a4da65 Compare July 14, 2020 11:58
@seiko2plus

Copy link
Copy Markdown
Member Author

@mattip, yes, gh-16857 wasn't included. I rebase it anyway.

@mattip

mattip commented Jul 14, 2020 •

Copy link
Copy Markdown
Member

ahh, I was trying to conserve CI resources. oh well. CircleCI is happy now anyway

@mattip
mattip merged commit c8d272d into numpy:master Jul 14, 2020
@mattip

mattip commented Jul 14, 2020

Copy link
Copy Markdown
Member

Thanks @seiko2plus

@mattip mattip added the component: SIMD Issues in SIMD (fast instruction sets) code or machinery label Jul 21, 2020
@seiko2plus
seiko2plus deleted the ccopt_fix_inc_tmp_dir branch January 9, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: SIMD Issues in SIMD (fast instruction sets) code or machinery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants