Repository navigation
BUG: fix typo in polydiv that prevented promotion to poly1d - #17053
Merged
Merged
Conversation
eric-wieser
reviewed
Aug 11, 2020
eric-wieser
changed the title
Member
|
It might be good to add a test for the return type of |
28 of 35 tasks
|
closes #17076 |
Member
|
@Dahlia-Chehata: Not sure it was really worth opening an issue about that given we already have the patch, but no harm done. |
|
@eric-wieser you are right, but I discovered this PR after I already had opened the issue. |
eric-wieser
reviewed
Aug 14, 2020
Comment on lines
+250
to
+251
| assert_equal(isinstance(s, np.poly1d) == True) | ||
| assert_equal(isinstance(t, np.poly1d) == True) |
Member
There was a problem hiding this comment.
Suggested change
| assert_equal(isinstance(s, np.poly1d) == True) | |
| assert_equal(isinstance(t, np.poly1d) == True) | |
| assert isinstance(s, np.poly1d) | |
| assert isinstance(t, np.poly1d) |
eric-wieser
reviewed
Aug 14, 2020
Comment on lines
+247
to
+249
| d = np.poly1d([1, 2, 3]) | ||
| c = [1, 2, 3] | ||
| s, t = np.polydiv(d, c) |
Member
There was a problem hiding this comment.
This test is backwards - its the one that passed before this patch.
Probably fine to keep it, but you should add one with the arguments in the other order too.
rossbar
approved these changes
Aug 17, 2020
rossbar
left a comment
rossbar
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @jakobjakobson13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #17012 item 16.
Closes #17076