Skip to content

Change mode of open in func write_file() - #17054

Closed
jakobjakobson13 wants to merge 1 commit into
numpy:masterfrom
jakobjakobson13:genapi_write_file_mode
Closed

Change mode of open in func write_file()#17054
jakobjakobson13 wants to merge 1 commit into
numpy:masterfrom
jakobjakobson13:genapi_write_file_mode

Conversation

@jakobjakobson13

@jakobjakobson13 jakobjakobson13 commented Aug 11, 2020

Copy link
Copy Markdown
Contributor

See #17012 item 1

@eric-wieser

eric-wieser commented Aug 11, 2020

Copy link
Copy Markdown
Member

This looks wrong to me - data is unicode.

@jakobjakobson13 jakobjakobson13 mentioned this pull request Aug 11, 2020
Open
28 of 35 tasks
@jakobjakobson13

jakobjakobson13 commented Aug 11, 2020

Copy link
Copy Markdown
Contributor Author

This looks wrong to me - data is unicode.

Okay, I'll close it then.

@eric-wieser

eric-wieser commented Aug 11, 2020

Copy link
Copy Markdown
Member

Ci seems to agree with me.

In principle, we could use open(..., "w", encoding="utf8"), but I think:

  • We'd need to do that everywhere
  • This is likely to cause trouble on systems which do not use utf8 encoding by default

@jakobjakobson13

jakobjakobson13 commented Aug 11, 2020

Copy link
Copy Markdown
Contributor Author

Okay.

@jakobjakobson13
jakobjakobson13 deleted the genapi_write_file_mode branch August 18, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakobjakobson13 @eric-wieser