Skip to content

MAINT: Simplify check for key in dictionary - #17064

Closed
jakobjakobson13 wants to merge 1 commit into
numpy:masterfrom
jakobjakobson13:cleanup_datasource
Closed

jakobjakobson13 wants to merge 1 commit into
numpy:masterfrom
jakobjakobson13:cleanup_datasource

Conversation

@jakobjakobson13

@jakobjakobson13 jakobjakobson13 commented Aug 11, 2020 •

Copy link
Copy Markdown
Contributor

See #17012 item 28.

@jakobjakobson13

Copy link
Copy Markdown
Contributor Author

As "_file_openers" is a class, this does not seem to work. I'm closing it.

@eric-wieser

Copy link
Copy Markdown
Member

Better would be to implement __contains__ on the FileOpeners class in the trivial way - the current way is needlessly slow

@jakobjakobson13
jakobjakobson13 deleted the cleanup_datasource branch August 18, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants