Repository navigation
BUG: Fixes module data docstrings. - #17373
Merged
Merged
Conversation
melissawm
marked this pull request as draft
September 24, 2020 16:53
eric-wieser
reviewed
Sep 24, 2020
Member
Author
|
Testing with CI, I noticed were necessary to get the new test to run - but I'm not really sure if those are the right messages, as I'm not familiar with either PyPy or Windows. From #9673 and |
melissawm
marked this pull request as ready for review
September 24, 2020 19:14
28 of 35 tasks
charris
reviewed
Sep 25, 2020
|
|
||
| if (def.data == NULL) { | ||
| n = format_def(p, size, def) == -1; | ||
| n = format_def(p, size, def);// == -1; |
Member
There was a problem hiding this comment.
Might as well remove the comparison as comment it out.
Member
Author
There was a problem hiding this comment.
Sorry, that was supposed to go when I took the PR out of draft. Done!
eric-wieser
reviewed
Sep 26, 2020
| @pytest.mark.xfail(IS_PYPY, | ||
| reason="PyPy cannot modify tp_doc after PyType_Ready") | ||
| def test_module_docstring(self): | ||
| expected = "i : 'i'-scalar\nx : 'i'-array(4)\na : 'f'-array(2,3)\nb : 'f'-array(-1,-1), not allocated\x00\nfoo()\n\nWrapper for ``foo``.\n\n" |
Member
There was a problem hiding this comment.
This would be a good use of textwrap.dedent('"""...""")
Member
Author
There was a problem hiding this comment.
Thanks for the suggestion, I was not familiar with that :)
Member
|
Thanks Melissa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves printing of module data items, showing proper information via the module docstring.
Fixes #15325 and #15308