Repository navigation
BLD: circleCI- merge before build, add -n to sphinx - #17485
Conversation
Co-authored-by: Eric Wieser <[email protected]>
|
The added job works, but I am not sure the merge-with-head |
|
The downside of this PR is that it increases the doc build time. Does it make sense to do the nitpick checks after building and uploading the doc artifacts, to make this extra delay only matter to those fixing warnings? Or should we leave it as is to fix all of the warnings? |
I view this as a "temporary" step till we get the warning count down (but that could take a while). The CircleCI build time is 26 minutes (single process). Travis is running for ~55 minutes wall clock, 2hrs50 min process time, so I think the extra ~5 minutes are not going to slow down the PR turn-around time. |
Note that for doc-only PRs, the travis build time doesn't really matter. Still, 5 minutes over 25 is not a disaster. |
eric-wieser
left a comment
eric-wieser
left a comment
There was a problem hiding this comment.
Let's put this in and see if we can knock down the number of warnings
|
Thanks Matti. The big drain on the testing seems to be PRs with a dozen small updates. |
3 participants
Add a merge to the checkout step as per this comment to merge master into the PR.
Also add a step to show how many warnings are still being emitted with
sphinx-build -n ..., xref issue gh-13114. It should not cause the build to fail, but those who are interested can dive into the log files and see the progress.